[Freeciv-Dev] Re: (PR#8624) New clima function to best handle terrain place, used to place poles.

["Marcelo Burda" <mburda@xxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8624 >

Le ven 07/05/2004 à 18:08, Jason Short a écrit :
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8624 >
> 
> Marcelo Burda wrote:
> 
> >>near_singularity() shouldn't use the hard-coded city iteration.  Use
> >>is_valid_city_coords, or a city iterator, or just use circle_iterate.  
> > 
> > singularity no need to be exact a city iterators.
> > I am choice one of more basic and simplest iterators there. this is one
> > of fondamentals iterators to be adapted to topologies.(this is the right
> > choice) spetialy i can't use circle_iterate  this call
> > map_distance_vector or any other operator where future is (?).
> > Near_singularity() is moderate time  inefficient but this never need to
> > be change in future (expet if we like chage it) this function is only
> > called for map generator, were time is not the first point.
> 
> But you shouldn't use square_dxy_iterate, then skip past positions 
> yourself.  Either use square_iterate or circle_iterate.
> 
> And...
> 
> You can't hard-code the number of tiles.  This value would change under 
> a hex-tiled map.  Instead we need an else clause.  I guess this means 
> you need a hard-coded iterator.  Or maybe add an "else" clause to one of 
> the existing iterators.
> 
mmm... i need there this function. 
In the hex-tiled map you need to patch with a else for the hard coded
number. the concept of these patch is based in the way i need implement
iterators, then i am no choice about the hard coded number.
probably i go use a litle sqare today, this will change in exteded
topologies patch.
i need to see your hex patch to make choices but i ll am no make it
today

> jason
-- 
 . /  .     '    ,    .      (*)   '        `     '      `    .    
  |    ,  |   `     ,     .      ,   '  Marcelo Julián Burda      .
 /  '     \     `     \@_     '      .        '      `        '    
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~