[Freeciv-Dev] Re: (PR#8640) Target "*.ruleset" at data/nation/Makefile

["Jason Short" <jshort@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8640 >


>   Attached patch at least allows me to work. I'm not tested at all if it
> makes what it should. I'm currently happy as it stops fatal make errors
> for me.
>   There is also possibility that I have used parameters that are illegal
> in some platforms, for some command.
>   It should fix both compiling from separate builddirs and make
> Makefile.am to be really regenerated whenever list of rulesets changes,
> not when some individual ruleset changes.

1.  I don't like the use of an extra generated file.  Seems like you
should be able to use an internal variable here instead.

2.  Are you sure , will never be present in the path?  I recently had a
similar problem in tests/*.sh and I used \ as the regex separator.  We
should be consistent here, but I don't know what is best.

jason