[Freeciv-Dev] Re: (PR#8640) Target "*.ruleset" at data/nation/Makefile

["Jason Short" <jshort@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8640 >

Marko Lindqvist wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8640 >
> 
> make[3]: *** No rule to make target `*.ruleset', needed by 
> `Makefile.am'.  Stop.
> 
> 
>   Looking Makefile.am.sh, rule to generate Makefile.am actually have 
> dependency generated as $(echo *.ruleset). I don't even understand what 
> it tries to achieve. Why would Makefile.am depend on all rulesets? 
> Probably Makefile.am is meant to be rebuilt when ever _list of_ rulesets 
> changes, but implementation is far from that in every aspect...

It's a clever but somewhat broken way to make sure new nations get added 
to Makefile.am automatically.  So if a new ruleset is added and you run 
"make" Makefile.am (depending on this new ruleset) will be rebuilt to 
include it.

This is broken because you generally have to rerun autogen.sh again 
anyway for the changes to take effect.

I guess on your system "echo *.ruleset" outputs "*.ruleset" rather than 
an actual list of the ruleset files?

>   Well, this individual problem might is not worth fixing now, since it 
> seems to me that whoever wrote this file, did not really understand what 
> was doing and it should be rewritten completely. I'll volunteer, but 
> give no estimations when I have time to actually do it. This is, of 
> course, unless someone can explain why it must be the way it is. Maybe 
> (minimum) implementation as Makefile.am puts too much constraints to 
> what kind of 'make' programs one can use? (But I think it's quite 
> unlikely that more limited 'make' can use Makefiles generated by 
> automake -> autoconf anyway, not to mention compiler generated dependencies)

Try searching the archives.  The old method required manual changes. 
Someone got the idea it would be good to automate this.  But the result 
isn't perfect.

jason