[Freeciv-Dev] (PR#8646) Wrong veteran handling in AI

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8646 >


ai/advmilitary.c:793:51: Function unittype_att_rating expects arg 2 to be int 
gets fc_bool: will_be_veteran

Context:
      /* TODO: Case for B_AIRPORT. -- Raahul */
      bool will_be_veteran = (move_type == LAND_MOVING ||
                              player_knows_improvement_tech(pplayer, B_PORT));
      int attack = unittype_att_rating(unit_type, will_be_veteran,
                                       SINGLE_MOVE,
                                       unit_types[unit_type].hp);

unittype_att_rating wants an int but gets a bool.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "A common mistake that people make, when trying to design 
  something completely foolproof is to underestimate the 
  ingenuity of complete fools."
    -- Douglas Adams in Mostly Harmless