Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2004:
[Freeciv-Dev] (PR#8526) city_draw_iterate macro 		Home

[Freeciv-Dev] (PR#8526) city_draw_iterate macro

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: mburda@xxxxxxxxx
Subject: [Freeciv-Dev] (PR#8526) city_draw_iterate macro
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Wed, 28 Apr 2004 22:30:54 -0700
Reply-to: rt@xxxxxxxxxxx 
<URL: http://rt.freeciv.org/Ticket/Display.html?id=8526 >

> [mburda - Wed Apr 28 07:45:10 2004]:
> 
> Hello,
> _ This iterator make more easy to understand the logic of code and more
> easy to extend it.

Hey,

This is practically identical to my city_draw_iterate patch in PR#8526.
 Please take a look at my patch and see what you think.

We should use is_valid_city_coords here instead of the hard-coded
position check.  And I think the macro should be confined to
citydlg_common.c; nobody else should ever need it.

About the name I'm not sure.

jason
[Prev in Thread] Current Thread [Next in Thread]