Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2004:
[Freeciv-Dev] (PR#8527) duplicated code in city output functions
Home

[Freeciv-Dev] (PR#8527) duplicated code in city output functions

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] (PR#8527) duplicated code in city output functions
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 16 Apr 2004 08:33:09 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8527 >

city.c has functions like

   get_xxx_tile()
   city_get_xxx_tile()

   xxx = {food, trade, shields}

which have different, mostly duplicated backends functions.  This is 
because extra calculations must be done to determine the output for a 
particular city versus the general output.

These function pairs should each have a single backend.  This backend 
may take a NULL pcity for the general case.

jason




[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] (PR#8527) duplicated code in city output functions, Jason Short <=