[Freeciv-Dev] Re: (PR#8591) win32: client crashes on middle click

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8591 >

James Canete wrote:

> Version 2.

Casts like this are dangerous.  Are you sure the function type matches? 
  Can you change the function type that list_impr_or_unit_select takes?

+      list_impr_or_unit_select(hLst,num,(TestCityFunc *)city_got_building);



Should be static:

+bool popit_is_orders;



If you update_map_canvas_visble, you need not do the other updates.  Not 
that it matters much, really.

@@ -84,6 +87,9 @@
             cross_list++;
           }
        }
+      if (popit_is_orders) {
+       update_map_canvas_visible();
+      }


-jason