[Freeciv-Dev] Re: (PR#8591) win32: client crashes on middle click

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8591 >

James Canete wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8591 >
> 
> The win32 client crashes when middle-clicking terrain, because it uses
> the old parameter list of concat_tile_activity_text() when showing
> terrain information.
> 
> This patch updates this part to use text.[ch], it's basically cut and
> pasted from the gtk2 client.

You set is_orders but never use it.

When you release the mouse button, you have to do a redraw.  If 
is_orders is set this is an update_map_canvas_visible, otherwise it's 
just a dirty_all (update_map_canvas_visible would still do the trick, of 
course).  Do things get drawn correctly if you click (and release) on a 
unit on goto?

jason