[Freeciv-Dev] Re: (PR#8491) Re: Freeciv commit: kauf: A new connect dialog for the client. This allo...

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8491 >

Mike Kaufman wrote:

>>>+enum skill_levels { 
>>>+  NOVICE, 
>>>+  EASY, 
>>>+  NORMAL, 
>>>+  HARD, 
>>>+  EXPERIMENTAL,
>>>+  NUM_SKILL_LEVELS
>>>+};
>>>+
>>>+extern const char *skill_level_names[NUM_SKILL_LEVELS];
>>
>>Shouldn't/can't these be shared with the server.
> 
> possibly. devise a method and tell me.

This should definitely be done.  Should be easy.

>>>+  switch (packet->type) {
>>>+  case 0:
>>
>>Use enums.
> 
> we had this discussion already. the answer is no.

This enum should also be shared with the server.

>>>+#define MAX_LEN_PATH 4095
>>
>>See C99 and FILENAME_MAX.
> 
> I'm too lazy.

Uhh, bad.

jason