[Freeciv-Dev] Re: (PR#8486) Fullscreen Mode for Gtk 2 client

["andrearo@xxxxxxxxxxxx" <andrearo@xxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8486 >

On Sun, 11 Apr 2004, Jason Short wrote:
> andrearo@xxxxxxxxxxxx wrote:
> > This patch implements a Fullscreen mode for the Gtk 2 client.
> Full-screen mode sounds really good.  I'm unable to test it right now,
> though.
>
> Are all of the changes really necessary?  Stuff like

>
> is repeated dozens of times.  Is there some simpler solution?  Perhaps
>
>    void setup_dialog(GtkObject *shell)
>    {
>      if (dialogs_on_top || fullscreen_mode) {
>        /* ... */
>      } else {
>        /* ... */
>      }
>    }

Here's an updated patch. I made a function setup_dialog(), which handles
the dialogs. It must be called on all new dialog windows.

The function gtk_object_set_data() wasn't necessary, as
gtk_window_set_type_hint() already removes the dialog from the taskbar.

Andreas Røsdal