[Freeciv-Dev] Re: (PR#8490) Extended connection dialog tweaks+bugfix.

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8490 >

On Sun, Apr 11, 2004 at 05:01:35PM -0700, Vasco Alexandre da Silva Costa wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8490 >
> 
> Howdy. I saw the new extended connection dialog in action today. A fine
> piece of work. But it seemed to be missing a few stock items here and
> there, mnemonics, it also used radio buttons instead of checkboxes for
> boolean values.
> 
> This patch changes that.
> 
> Regarding the bug, a juicy little critter, in struct options_settable
> min/max/val/default_val all were defined as short when they really
> should be int. This resulted in unfortunate consequences for certain not
> so nice
> variable ranges such as those of seed, randseed and timeout. No protocol
> change was required since those fields were defined in there as int32
> already.

hmm yes.

most of these changes look ok. I'm not so sure about the checkboxes as it
gives a sort of ambiguity as to what you're actually picking. As for the
mnemonics, you need to add an activation signal to the radio buttons for
New/Load/Network.

-mike