[Freeciv-Dev] Re: (PR#8482) heights in gtk2 production dialog

["Vasco Alexandre da Silva Costa" <vasc@xxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8482 >

On Sat, 10 Apr 2004, Daniel L Speyer wrote:

>
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=8482 >
>
> The current setup of the worklist windows (NORMAL_TILE_HEIGHT whether it
> needs it or not) in gtk2 uses an awful lot of empty space.  It makes it
> more necessary to scroll and is (IMHO) ugly.  This patch auto-detects
> units' actual heights and uses them.

As long as it does not cut the image, this sort of patch is ok. But I do
not like the hard coded numbers and I think the right way to fix this
would be in the generic function in graphics.c not here.

Are you certain this patch will work as well with any tileset? I suspect
the flags/shields may be cut. It is debatable if those are necessary or
not, but better to not put them at all than to cut them.

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa