Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2004:
[Freeciv-Dev] (PR#8479) Compile fix for win32 (ext. conndlg)
Home

[Freeciv-Dev] (PR#8479) Compile fix for win32 (ext. conndlg)

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: akemnade@xxxxxxxxxxxxxxxxxxxxxxxx, use_less@xxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#8479) Compile fix for win32 (ext. conndlg)
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 10 Apr 2004 22:21:21 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8479 >

> [andi - Sat Apr 10 11:32:29 2004]:
> 
> This is a simple compile fix for the win32 client.

Here's a fix that adds the sys/wait configure check.  Tested under
gnu/linux with the gtk client.

Note that all these values should be static.  I suspect your server_pid
value is accessed in the GUI code?  That's probably bad...your code
should be merged into connectdlg_common.  (Which I believe would allow
the launch dialog to work in the gtk2/win32 client, for instance.)

> BTW: Why we are including network headers in both netintf.h and netintf.c?
> I don't think that is necessary.

Probably not, though it shouldn't be a problem.

jason



[Prev in Thread] Current Thread [Next in Thread]