Complete.Org: Mailing Lists: Archives: freeciv-dev: April 2004:
[Freeciv-Dev] (PR#8478) new connect dialog broke win32 build.
Home

[Freeciv-Dev] (PR#8478) new connect dialog broke win32 build.

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: use_less@xxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#8478) new connect dialog broke win32 build.
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Sat, 10 Apr 2004 22:13:08 -0700
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8478 >

> [use_less - Sat Apr 10 09:15:04 2004]:
> 
> This patch makes it build again.
> 
> It seems pretty straightforward, but I'm not sure if it breaks other
> builds in the process.

I don't think it will break other builds, but I don't think it's
entirely "right" either.

You shouldn't check stuff like !defined(__VMS).  That's just ugly.  A
configure check (like HAVE_KILL, HAVE_WAITPID, or at worst WIN32_NATIVE)
should be used instead.

And you shouldn't use AC_CHECK_HEADERS([sys/wait.h]).  Use
AC_HEADER_SYS_WAIT (IIRC) instead.

Of course the proper thing to do is change this to actually work for
win32.  I believe andi had a patch for that?

jason



[Prev in Thread] Current Thread [Next in Thread]