[Freeciv-Dev] (PR#8393) transported_by at the client

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=8393 >

Currently a unit that is transported is seen by some of the clients 
only.  For these clients this unit has punit->transported_by treated as 
a _boolean_ at the client side.  So the client knows the unit is 
transported (and thus knows not to animate it in movement) but doesn't 
know what unit is transporting it.  This was necessary in the past 
because punit->transported_by didn't have a consistent meaning even at 
the server.  But now it does.

There are several reasons why the client needs to know which unit is 
carrying the cargo.  They all boil down to one thing: managing 
transported units is now the responsibility of the player, not the 
server.  In the unit popup dialog the player needs to easily see which 
units are transporting which.  And to implement a load/unload command, 
the client needs to be able to determine which load/unloadings are possible.

So my proposal is that punit->transported_by should be sent to the 
client.  This is a fairly simple change.  The new invariant would be 
that for all units seen by the client punit->transported_by has the 
correct value.

Unless anyone objects I'll make up a patch for this shortly.

jason