Complete.Org: Mailing Lists: Archives: freeciv-dev: March 2004:
[Freeciv-Dev] (PR#7612) crop_sprite with a mask
Home

[Freeciv-Dev] (PR#7612) crop_sprite with a mask

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#7612) crop_sprite with a mask
From: "James Canete" <use_less@xxxxxxxxxxx>
Date: Fri, 19 Mar 2004 02:39:59 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7612 >

I tried out your patch (while trying to fix those annoying messy oceans
:), and there's a minor error in crop_sprite() in gui-win32/graphics.c.
 The new mask should be SRCPAINT'ed on, not SRCAND'ed.  That's because
it's the black parts of the mask on win32 that are unmasked, not the
white parts.

Also the whole second mask piece of code should be above the piece of
code that actually assigns the sprite.

Here's a patch that patches off your patch. :)

Otherwise it works fine, aside from the oceans which are still messy,
but look messy in a different way now.

-James Canete

Attachment: crop_sprite-fixwin32.diff
Description: Binary data


[Prev in Thread] Current Thread [Next in Thread]