Complete.Org: Mailing Lists: Archives: freeciv-dev: February 2004:
[Freeciv-Dev] Re: (PR#7499) problems with detachable panes
Home

[Freeciv-Dev] Re: (PR#7499) problems with detachable panes

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#7499) problems with detachable panes
From: "Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>
Date: Tue, 24 Feb 2004 13:59:00 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7499 >

On Tue, Feb 24, 2004 at 01:05:46PM -0800, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7499 >
> 
> Vasco Alexandre da Silva Costa wrote:
> 
> > I think I know why the bug happens. The code used to draw directly to
> > 'overview_canvas->window'. Now you copy the pointer to a struct, and use
> > that pointer. But what if the pointer value in the original
> > 'overview_canvas' was changed uh? Yep. Boom!
> 
> OK, so my idea for a fix is the ugliest.

> Here's a partial implementation of Raimar's idea.  Every time the common 
> code needs to know the window the GUI gives it.

> I'm not entirely sure that this is better.  If we do use this, then we 
> may eventually have to do the same thing for the mapview.  And of course 
> we'll need support for the other GUIs before using it.

Yes and yes. I think the patch is good since it allows the GUI more
control and has a low source code and runtime impact. Changing the
other GUI is easy.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Are you saying that you actually used the Classpath Java AWT classes in 
  addition to the GTK peers and got them to display something?
  Wow.  That's way better than I did and I wrote the code!"
    -- Aaron M. Renn in the classpath mailing list




[Prev in Thread] Current Thread [Next in Thread]