[Freeciv-Dev] (PR#7287) Extended Topologies

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7287 >

> [mburda - Sat Feb 07 14:31:54 2004]:

> I wait for your comments.

First of all, the patch needs to be split up.  You can start doing this
now, if you want.  One example: the city_map_iterate_known macro can
become its own patch.  There are many other examples.

Next, I'm not happy with the xsize/ysize/size/ratio setup.  If you
change the xsize nothing happens, and you can't figure out why.  At a
minimum the user needs an error message here.  (This is also something
that should be its own patch.  I'm not convinced that we need this.)

The topology_id isn't fully explained (in "help topology").  What are
topologies 5-15?  Why don't we have 22-31?

I'd like to set up the topology_id as a combination of bitfields:

Xwrap: 2 bits, 4 values:
Ywrap: 2 bits, 4 values:
  NONE, SIMPLEST, MOBIUS, REVERSED
iso: 1 bit

This is similar to what you have (I think), but the bit order is different.

so we end up with 32 different topologies (as you have).

Finally, examples.  The biggest problem we have is convincing people
that we should provide these topologies.  The biggest selling point will
probably be the quincunx topologies, which make a good approximation of
a sphere.  But I can't figure out how to turn your earth scenario into a
quincuncial earth, since I don't know what the topology values are.

jason