[Freeciv-Dev] Re: (PR#7344) Expanded Orders

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7344 >

On Thu, Jan 29, 2004 at 06:05:30AM -0800, Arnstein Lindgard wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7344 >
> 
> Expanded Orders is Mission Orders minus client interface.
> 
> Now expanding the struct unit_orders, not using unions or
> chained enums.

>  enum unit_orders {
> -  ORDER_MOVE, ORDER_FINISH_TURN,
> +  ORDER_MOVE, ORDER_FINISH_TURN, ORDER_NONE,

What is ORDER_NONE?

> +  /* "Actions" not technically "activities". */

You mean:

  One-shot actions are not part of "enum unit_activity".

?

> +  ORDER_AUTO_ATTACK, ORDER_AUTO_SETTLE, ORDER_BUILD_CITY,
> +  ORDER_BUILD_WONDER, ORDER_DISBAND, ORDER_HOMECITY,
> +  ORDER_TRADEROUTE, ORDER_UNLOAD,
> +  /* These duplicate items from "enum unit_activity". */
> +  ORDER_AIRBASE, ORDER_EXPLORE, ORDER_FALLOUT, ORDER_FORTIFYING,
> +  ORDER_FORTRESS, ORDER_IRRIGATE, ORDER_MINE, ORDER_PILLAGE,
> +  ORDER_POLLUTION, ORDER_ROAD, ORDER_RAILROAD, ORDER_SENTRY,
> +  ORDER_TRANSFORM,
>    ORDER_LAST
>  };

> +/* For client to determine which sprite to display. */
> +enum movement_type {
> +  GOTO_ORDERS, PATROL_ORDERS, STATIONARY_ORDERS
> +};

The values should get a prefix.

> +    /* Information for client to display sprites correctly. */
> +    enum unit_orders mission;       /* The last order in the list. */
> +    enum movement_type move_type;   /* Goto, Patrol, Stationary.   */

I really don't like this. We should really send the order list back to
the client. We agreed on this before and the above is only a kludge
around this.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Of course, someone who knows more about this will correct me if I'm
  wrong, and someone who knows less will correct me if I'm right."
    -- David Palmer (palmer@xxxxxxxxxxxxxxxxxx)