[Freeciv-Dev] (PR#7254) 20040116 win32 client crashes windows2000

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7254 >

> [i-freeciv-lists@xxxxxxxxxxxxx - Thu Jan 29 11:20:49 2004]:
> 
> On Thu, Jan 29, 2004 at 02:24:00AM -0800, James Canete wrote:
> > 
> > <URL: http://rt.freeciv.org/Ticket/Display.html?id=7254 >
> > 
> > well, i got my build to crash...by adding an assert.  :)
> > 
> > to the function is_ground_unittype(Unit_Type_id id) in
> > common/unittype.c, I added the line:
> > assert(id >= 0 && id < U_LAST && id < game.num_unit_types);
> > 
> > Loading the save, setting timeout to -1, and starting the server
> > triggers this assert.
> > 
> > I found this by disassembling the CVS win32 server executable,
> > disassembling my own mingw build, and comparing the two with a
> > fine-toothed comb.
> 
> Good work.
> 
> Now the question which of the values is out of scale. If it is "id"
> than the caller may be cause. However if it is "game.num_unit_types"
> then we have memory corruption somewhere.

This is the same as PR#7289.  It's not unique to win32, although it only
seems to cause a crash there.

jason