Complete.Org: Mailing Lists: Archives: freeciv-dev: January 2004:
[Freeciv-Dev] Re: (PR#7229) Re: Re: Freeciv commit: ali: Add macro is_c
Home

[Freeciv-Dev] Re: (PR#7229) Re: Re: Freeciv commit: ali: Add macro is_c

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: a-l@xxxxxxx
Subject: [Freeciv-Dev] Re: (PR#7229) Re: Re: Freeciv commit: ali: Add macro is_city_hilited().
From: "Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>
Date: Sat, 10 Jan 2004 13:00:32 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7229 >

On Sat, Jan 10, 2004 at 12:52:26PM -0800, Jason Short wrote:
> > Do you expect a piece of silicon to generate an interrupt precisely
> > at L1 which may change punit_focus via a GTK timer?
> 
> This is wrong on many levels.
> 
> 2.  Freeciv clients are single-threaded, so there will never be an
> interrupt to change the value at L1.

Don't be sure in this regard. If the (gtk) timer is implemented with
alarm(2) or similar and not select(2) it isn't single-threaded. Also
the SDL client uses multiple threads. However I'm not sure here about
the impact.

I prefer the second form with a temp variable but because it reduces
the amount of source code.

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "Like the ad says, at 300 dpi you can tell she's wearing a
  swimsuit. At 600 dpi you can tell it's wet. At 1200 dpi you
  can tell it's painted on. I suppose at 2400 dpi you can tell
  if the paint is giving her a rash."
    -- Joshua R. Poulson




[Prev in Thread] Current Thread [Next in Thread]