[Freeciv-Dev] Re: (PR#4044) veteran level patch

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=4044 >

On Mon, 17 Nov 2003, Raimar Falke wrote:
> There should be IMHO a type for the veteran level.
>
> You also need to change the description of B_SUNTZU. Maybe it is
> necessary to add an option to make the chance 100% if you have
> B_SUNTZU and play the civ1 ruleset.
>
> There should be access functions. I don't like
> "get_unit_type(type)->veteran[veteran].power_fact"

I've overlooked this post unintentionally. No, I don't want a new type for
veteran levels. Sun Tzu will be 100%, since 50% (default) + 50% (new Sun
Tzu) is 100%, so no description change needed, since there is no change in
behaviour. Access functions I'll look at, but I'm not sure it is worth
doing, since you miss out on optimizations by forcing a lot of extra calls
to get_unit_type that could be avoided (in eg tight loops).

  - Per