[Freeciv-Dev] Re: (PR#7213) is_attack_unit(punit)

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=7213 >

Raimar Falke wrote:
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=7213 >

>>-  if (is_military_unit(punit) && unit_type(punit)->attack_strength > 0
>>-      && map_get_city(punit->x, punit->y))
>>+  }
>>+  if (is_attack_unit(punit) && map_get_city(punit->x, punit->y)) {
>>     return TRUE;
>>+  }
> 
> 
> This doesn't seem an equivalent transformation.

is_attack_unit implies is_military_unit.  But some military units may 
have 0 attack.

What if a non-military unit had nonzero attack rating?

jason