[Freeciv-Dev] Re: (PR#6935) AI sends transports with settlers off exploring

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6935 >

On Mon, 24 Nov 2003, Gregory Berkolaiko wrote:
> > The problem seems to be the mysterious call to ai_clear_ferry() in
> > ai_manage_unit(). Why is it there??
> >
> > Removing it fixes the problem. Greg?
>
> Don't.
>
> The reason for the clear_ferry is that the unit, when it's dealt with in
> it's ai_manage_ function, can try to do lots of various things. Most of
> them do not involve the ferry that the unit has requested last turn.

Ugh. This is why I wrote ai_unit_new_role(), you know. _All_ 'changing
your mind' stuff goes through there. This is the place for such calls.

> So we either have to trace every place where a unit changes its mind
> about using a boat and free the boat there

Shouldn't be too hard, I think.

> This works fine with military units because in ai_manage_military the unit
> thinks "I am in the middle of the ocean, to go killing I need a boat" and
> gets the boat back.

What if the ferry is called first? This looks random to me.

  - Per