[Freeciv-Dev] Re: (PR#4044) veteran level patch

["Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=4044 >

On Mon, Nov 17, 2003 at 07:08:12AM -0800, Per I. Mathisen wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=4044 >
> 
> This one is based on Rafal's latest edition of the veteran level patch.
> 
> I removed client support in all clients except gtk1&2 (sorry - no idea on
> how to fix). Removed a lot of spurious changes that have nothing to do
> with veteran levels. Also removed barbarian veteran levels, unlimited
> veteran levels, per unit veteran sprites, short names, drawing veteran
> level only for own units, and per-unit trireme loss chance. Work raise
> chance and raise chance is same for all units. Fixed stack icon vs
> veterancy icon bug. Units can now have different number of veterancy
> levels, up to a maximum of 10. New unit flag F_NO_VETERAN to disable
> veterancy for some unit types. Diplomat escape chance based on
> game.diplchance (game.diplchance + 5% each vet level).
> 
> I plan on committing this eventually with rulesets set to values that
> makes gameplay similiar to current rules. Then we should have
> a discussion about what we should use as default rules; better to discuss
> this when suggestions can be tested.
> 
> You will need one of the new tilesets with veterancy icons, discussed on
> the list recently, to test this patch.

There should be IMHO a type for the veteran level.

You also need to change the description of B_SUNTZU. Maybe it is
necessary to add an option to make the chance 100% if you have
B_SUNTZU and play the civ1 ruleset.

There should be access functions. I don't like
"get_unit_type(type)->veteran[veteran].power_fact"

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 A life? Cool! Where can I download one?