Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2003:
[Freeciv-Dev] Re: (PR#6822) some variable-sized arrays
Home

[Freeciv-Dev] Re: (PR#6822) some variable-sized arrays

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#6822) some variable-sized arrays
From: "Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Tue, 11 Nov 2003 08:10:47 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6822 >

On Mon, 10 Nov 2003, Jason Short wrote:

> The attached patch replaces some malloc'd arrays with variable-sized 
> stack arrays.  One memory leak is fixed in the process.
> 
> This should be faster, but my tests didn't show a measurable difference 
> (on systems with inefficient malloc calls this may make an impact - but 
> then those systems aren't likely to compile C99 anyway).  It's also 
> safer and more legible.

Why should it make a difference?  Aren't variable-sized arrays mplemented 
via malloc?  Or because of the clearly defined scope the memory 
management is easier?

G.





[Prev in Thread] Current Thread [Next in Thread]