[Freeciv-Dev] Re: (PR#6822) some variable-sized arrays

["Per I. Mathisen" <per@xxxxxxxxxxx>]

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6822 >

On Mon, 10 Nov 2003, Raimar Falke wrote:
> > The attached patch replaces some malloc'd arrays with variable-sized
> > stack arrays.One memory leak is fixed in the process.
> >
> > This should be faster, but my tests didn't show a measurable difference
> > (on systems with inefficient malloc calls this may make an impact - but
> > then those systems aren'tlikely to compile C99 anyway).It's also
> > safer and more legible.
>
> I don't see that the benefits (safer) outweigh the costs (change must
> be done, compiler or other tools doesn't understand it).

We already use such arrays elsewhere.

This might have considerable speed impact on win32 platform, since I hear
malloc is extremely slow there, and this patch removes _a lot_ of mallocs.

  - Per