Complete.Org: Mailing Lists: Archives: freeciv-dev: November 2003:
[Freeciv-Dev] Re: (PR#6822) some variable-sized arrays
Home

[Freeciv-Dev] Re: (PR#6822) some variable-sized arrays

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#6822) some variable-sized arrays
From: "Raimar Falke" <i-freeciv-lists@xxxxxxxxxxxxx>
Date: Mon, 10 Nov 2003 22:59:42 -0800
Reply-to: rt@xxxxxxxxxxx

<URL: http://rt.freeciv.org/Ticket/Display.html?id=6822 >

On Mon, Nov 10, 2003 at 04:56:27PM -0800, Jason Short wrote:
> 
> <URL: http://rt.freeciv.org/Ticket/Display.html?id=6822 >
> 
> The attached patch replaces some malloc'd arrays with variable-sized 
> stack arrays.  One memory leak is fixed in the process.
> 
> This should be faster, but my tests didn't show a measurable difference 
> (on systems with inefficient malloc calls this may make an impact - but 
> then those systems aren't likely to compile C99 anyway).  It's also 
> safer and more legible.

I don't see that the benefits (safer) outweigh the costs (change must
be done, compiler or other tools doesn't understand it).

        Raimar

-- 
 email: rf13@xxxxxxxxxxxxxxxxx
 "The two rules for success in life are:
  1) Never tell them everything you know."




[Prev in Thread] Current Thread [Next in Thread]