[Freeciv-Dev] Re: gtk clients: translate_menu_path

[Vasco Alexandre Da Silva Costa <vasc@xxxxxxxxxxxxxx>]

On Thu, 16 Oct 2003, Per I. Mathisen wrote:

> I just read an old profile of the gtk2 client done by Thomas, and I
> noticed that 18% of CPU time was spent inside translate_menu_path(). This
> is a function that is called once every menu item every turn, at least.
>
> It is a quite expensive function. Is it not possible to make this function
> calculate the result once only, and cache it? Surely the result does not
> change throughout the game for the same set of input. How about putting
> the translated string into hashlist, for instance? Alternatively, we could
> the uses of it turn it into a macro, and make some fancy use of static
> strings to hold this data. This would be even faster.

Here, this uses an hashtable lookup. :-D

---
Vasco Alexandre da Silva Costa @ Instituto Superior Tecnico, Lisboa

menu_trans.diff
Description: Text document