Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2003:
[Freeciv-Dev] Re: (PR#6442) gen5 wrapping
Home

[Freeciv-Dev] Re: (PR#6442) gen5 wrapping

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#6442) gen5 wrapping
From: "Jason Short" <jshort@xxxxxxxxxxxxxx>
Date: Tue, 14 Oct 2003 23:59:13 -0700
Reply-to: rt@xxxxxxxxxxxxxx

--On Tuesday, October 14, 2003 10:46 PM -0400 Ross Wetmore 
<rwetmore@xxxxxxxxxxxx> wrote:

>
> Gregory Berkolaiko wrote:
>> On Mon, 13 Oct 2003, Jason Short wrote:
>>
>>> Jason Short wrote:
> [...]
>> I tend to believe Ross on the optimization but I don't think it's a big
>> deal, extra 4 calls.  And I am not sure why topo_has_flag is considered
>> a  temporary measure.
>
> Actually it is far worse as it breaks the optimization of any code block
> where the globals are accessed. This can have far more extensive effects.
>
> Jason missed the global vs local factor completely as well, or failed to
> really understand the significance of it.

You may want to look at the code again.  There is no significance.

jason




[Prev in Thread] Current Thread [Next in Thread]