Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2003:
[Freeciv-Dev] Re: (PR#6442) gen5 wrapping
Home

[Freeciv-Dev] Re: (PR#6442) gen5 wrapping

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#6442) gen5 wrapping
From: "Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Tue, 14 Oct 2003 03:25:59 -0700
Reply-to: rt@xxxxxxxxxxxxxx

On Mon, 13 Oct 2003, Jason Short wrote:

> Jason Short wrote:
> > This simple patch replaces two gen5 wrapping constants with queried 
> > topology values.
> 
> Here's an alternative form that makes Ross happy, at the cost of being 
> less readible.

I prefer the first version on the account of the name "xnowrap" being
crap.  X now rap?  What does that mean?

I tend to believe Ross on the optimization but I don't think it's a big 
deal, extra 4 calls.  And I am not sure why topo_has_flag is considered a 
temporary measure.

So my vote is for the first version.

G.





[Prev in Thread] Current Thread [Next in Thread]