Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2003:
[Freeciv-Dev] Re: (PR#6411) genlist cleanup 		Home

[Freeciv-Dev] Re: (PR#6411) genlist cleanup

[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#6411) genlist cleanup
From: "Per I. Mathisen" <per@xxxxxxxxxxx>
Date: Thu, 9 Oct 2003 14:12:42 -0700
Reply-to: rt@xxxxxxxxxxxxxx 
On Tue, 7 Oct 2003, Jason Short wrote:
> I'm really not happy with lines like this:
>
> -     ITERATOR_NEXT(ent_iter);
> -     ITERATOR_NEXT(col_iter);
> +     ent_link = ent_link->next;
> +     col_link = col_link->next;
>
> at the least, let's change things to
>
> #define ITERATOR_NEXT(iter) ((iter)->next)
>
> ent_link = ITERATOR_NEXT(ent_link);

What does this gain us?

> although this should probably use a properly-named speclist
> macro/function instead.

Like what?

  - Per
[Prev in Thread] Current Thread [Next in Thread]