Complete.Org: Mailing Lists: Archives: freeciv-dev: October 2003:
[Freeciv-Dev] Re: (PR#6410) make helpdata.c use speclist
Home

[Freeciv-Dev] Re: (PR#6410) make helpdata.c use speclist

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#6410) make helpdata.c use speclist
From: "Per I. Mathisen" <per@xxxxxxxxxxx>
Date: Mon, 6 Oct 2003 10:10:59 -0700
Reply-to: rt@xxxxxxxxxxxxxx

On Mon, 6 Oct 2003, Jason Short wrote:
> > -pitem = ITERATOR_PTR(help_nodes_iterator);
> > -ITERATOR_NEXT(help_nodes_iterator);
> > +pitem = help_nodes_iterator->dataptr;
> > +help_nodes_iterator = help_nodes_iterator->next;
...
> Aren't there functions to retrieve this data?

Yes, but the problem is that helpdata.c implements its own (ugly)
iterator, and I see no point in trying to kludge in some standard way to
fetch data from inside such an self-made, high-level iterator kludge.
Instead, the existing kludge should be redesigned and removed. I don't
know how.

We have a similar but smaller problem in registry.c which I will address
later.

  - Per




[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] Re: (PR#6410) make helpdata.c use speclist, Per I. Mathisen <=