[Freeciv-Dev] Re: (PR#6410) make helpdata.c use speclist

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

Per I. Mathisen wrote:
> One of the last holdouts of direct use of the genlist, the ugly helpdata
> list implementation, is here transformed into a speclist. Much nicer.

>    check_help_nodes_init();
> -  pitem = ITERATOR_PTR(help_nodes_iterator);
> -  ITERATOR_NEXT(help_nodes_iterator);
> +  pitem = help_nodes_iterator->dataptr;
> +  help_nodes_iterator = help_nodes_iterator->next;

It seems very bad to access the fields of the list directly.  For one 
thing, this gets rid of type checking, right?  Aren't there functions to 
retrieve this data?

jason