Complete.Org: Mailing Lists: Archives: freeciv-dev: September 2003:
[Freeciv-Dev] Re: (PR#6200) disbanding a transporter must move its cargo
Home

[Freeciv-Dev] Re: (PR#6200) disbanding a transporter must move its cargo

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#6200) disbanding a transporter must move its cargo
From: "Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Fri, 19 Sep 2003 10:05:57 -0700
Reply-to: rt@xxxxxxxxxxxxxx

On Fri, 19 Sep 2003, Per I. Mathisen wrote:

> Yep. The code looks ok, though:
> 
> /* No need to wipe the cargo unless it's a ground transporter. */
> +  wipe_cargo &= is_ground_units_transport(punit);

I also noticed this.

> There is no reason to wipe the cargo of a ground units transporter which
> is also itself a ground unit. Check that we are on ocean terrain.

Should we rather check that we are in an opposite terrain (land for boats,
sea for pedestrians)?  It could be that (small) ships are transported by
land.  This is how Vikings got to Constantinople for example.

G.





[Prev in Thread] Current Thread [Next in Thread]