[Freeciv-Dev] Re: (PR#6158) police stations and women suffrage

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

Genevieve Gracian wrote:
> On Mon, 15 Sep 2003 12:19:40 -0700
> "Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx> wrote:
> 
> 
>>On Mon, Sep 15, 2003 at 12:16:54PM -0700, Genevieve Gracian wrote:
>>
>>>On Mon, 15 Sep 2003 09:25:30 -0700
>>>"Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx> wrote:
>>>
>>>
>>>>Anyone want to provide a patch?  Please check all rulesets.
>>>
>>>Hoping this patch is ok.
>>
>>you sure you want equiv_repl instead on equiv_dupl?
> 
> 
> equiv_dupl don't change current behavior for police station/women's
> suffrage. Also, for all buildings which can be replaced by a
> never-obsoleted wonder equiv_repl is currently used and only for city
> walls equiv_dupl is used. 
> 
> I have no clear opinion of what would be better between equiv_repl and
> equiv_dupl but think anyway that all similar cases of building/wonder
> should have the same behavior.
> 
> Using equiv_dupl would prevent one of the ways of stockpiling production
> and that's imho the main question here.

Based on this logic equiv_repl should be used.

Fundamentally these flags shouldn't be needed at all, though.  Once 
gen-effects is in place, it should all be automatically calculated from 
the ruleset.  Freeciv should be able to determine that Police Stations 
are redundant with Women's Suffrage, and that the latter is never 
obsoleted.  City Walls are redundant with Great Wall, but the later is 
obsoleted.  Thus we can get different behavior at the interface end 
without lots of ruleset work.

There is still the question of when you should be allowed to build a 
redundant building.  There's always the chance that the effect it is 
redundant with will be lost (in a variety of different ways).

jason