[Freeciv-Dev] Is anybody there? [was Re: Re: HERE'S THE PATCH Re: (PR#5378) Diplomacy information in map middle-click]

["Daniel L Speyer" <dspeyer@xxxxxxxxxxx>]

Hello?

I submitted the fixed version of this patch almost a week ago.  Everyone 
liked it at the time.  There are no outstanding issues.  I've been 
playing with it and it works well.

You know, in order for freeciv to progress, it's nessesary to actually 
apply patches once they're finished, not simply let them pile up in rt.

Not that I'm bitter or anyhting....

--Daniel Speyer

Daniel L Speyer wrote:

>Genevieve Gracian wrote:
>
>  
>
>>On Wed, 3 Sep 2003 18:11:59 -0700
>>"Daniel L Speyer" <dspeyer@xxxxxxxxxxx> wrote:
>>
>> 
>>
>>    
>>
>>>When?  And what characters?  I can't reproduce this.
>>>   
>>>
>>>      
>>>
>>On both gtk and xaw clients (but not gtk+) when middle cliking on any unit 
>>e.g:
>>
>>Unit: Explorer(SiouxWEIRD_STRING)
>>
>>note WEIRD_STRING is the same for all units at the same time.
>>
>>I guess it's the "tmp" in :
>>
>>    
>>
>You are right, I forgot to initialize tmp.  I don't know why I never saw 
>anything wrong, but wild pointers are like that.
>
>Here's the fixed version.
>
>--Daniel
>
>  
>
>>my_snprintf(buf, sizeof(buf), _("\nUnit: %s(%s%s)"), ptype->name,
>>      get_nation_name(unit_owner(punit)->nation), tmp)
>>
>>wich doesn't fit to other clients than gtk+ (tested with both 24/08 and 
>>yesterday
>>version of cvs).
>>
>>--
>>G. Gracian
>>
>> 
>>
>>    
>>