[Freeciv-Dev] Re: (PR#5439) use of adjust_terrain_param

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Tue, 26 Aug 2003, Karen Yeats wrote:

> In #2748 adjust_terrain_param itself was fixed.  However sometime the
> use of adjust_terrain_param doesn't make sense.  In particular it is
> called immediately after you set a terrain variable in the server.  The
> idea presumably was to keep the terrain variables as percents at all
> times.  However this is not a sensible thing to do for two reasons. 
> First it is counterintuitive as it makes the terrain variables
> non-idempotent.  #994 discusses this (note that on #994 I falsely
> claimed that #2748 fixed this, it doesn't, but this new patch does). 
> Second it makes it difficult to set a number of terrain variables to
> particular percents since each variable changes whenever you change one
> of them.  

"Non-idempotent" is a grand word to use...
Anyway it's a funny bug, just try to say "set forest 100" a few times and 
then say "show".

And the fix is good.

But it also transpired that what you ask for in parameters is often not 
what you get, will be reported separately.

G.