[Freeciv-Dev] (PR#5439) use of adjust_terrain_param

["Karen Yeats" <kayeats@xxxxxxxxxxxx>]

Hello.  Another quick patch for today.

In #2748 adjust_terrain_param itself was fixed.  However sometime the
use of adjust_terrain_param doesn't make sense.  In particular it is
called immediately after you set a terrain variable in the server.  The
idea presumably was to keep the terrain variables as percents at all
times.  However this is not a sensible thing to do for two reasons. 
First it is counterintuitive as it makes the terrain variables
non-idempotent.  #994 discusses this (note that on #994 I falsely
claimed that #2748 fixed this, it doesn't, but this new patch does). 
Second it makes it difficult to set a number of terrain variables to
particular percents since each variable changes whenever you change one
of them.  

I think the simplest and best solution is simply to change to percents
once and for all when generating the map and not to call
adjust_terrain_param earlier.  This patch implements this.

Karen

adjustuse.diff
Description: adjustuse.diff