[Freeciv-Dev] (PR#4815) Re: [FreeCiv-Cvs] glip: Move some asserts around ... (PR#4816)

["Christian Knoke" <chrisk@xxxxxxxxx>]

On Mon, Aug 11, 2003 at 10:21:00AM -0700, freeciv@xxxxxxxxxxxxxxxxxxx wrote:
> This is an automated notification of a change to freeciv cvs, 
> on Mon Aug 11 10:12:06 PDT 2003 = Mon Aug 11 17:12:06 2003 (GMT)
> by Gregory Berkolaiko <Gregory.Berkolaiko@xxxxxxxxxxxx>
> 
> ---- Files affected:
> 
> freeciv/client goto.c
> 
> ---- Log message:
>       Tag: HEAD
> 
> Move some asserts around in client goto code, before they annoy more people
> and RT overflows with their complaints.
> 
> Reported by Jason and Christian Knoke, patch by Jason.

While this basically makes the GOTO usuable again, it is still easy to get
various core dumps and asserts when you play a bit around with 'G' and mouse
click. I've tested plain CVS and CVS w/ goto_route-2.diff (related to PR#4811
and PR#4683).

Besides the crashes, goto_route-2.diff works ok.


398         dest_path->length = src_path->length;
(gdb) bt
#0  pft_concat (dest_path=0x0, src_path=0x0) at pf_tools.c:398
#1  0x0806cb85 in send_goto_route (punit=0x83ac100) at goto.c:544
#2  0x0806b43c in do_unit_goto (x=42, y=15) at control.c:1386
#3  0x0806b20a in do_map_click (xtile=42, ytile=15) at control.c:1317
#4  0x0807010b in action_button_pressed (canvas_x=529, canvas_y=256) at
mapctrl_common.c:86
#5  0x0809f7bf in butt_down_mapcanvas (w=0x83269a8, ev=0x8346028) at
mapctrl.c:337
#6  0x400e1f2f in gtk_marshal_BOOL__POINTER () from /usr/lib/libgtk-1.2.so.0
#7  0x40114268 in gtk_handlers_run () from /usr/lib/libgtk-1.2.so.0
#8  0x4011363f in gtk_signal_real_emit () from /usr/lib/libgtk-1.2.so.0
#9  0x40111597 in gtk_signal_emit () from /usr/lib/libgtk-1.2.so.0
#10 0x4014a4ec in gtk_widget_event () from /usr/lib/libgtk-1.2.so.0
#11 0x400e1e65 in gtk_propagate_event () from /usr/lib/libgtk-1.2.so.0
#12 0x400e0eaf in gtk_main_do_event () from /usr/lib/libgtk-1.2.so.0
#13 0x40195dd4 in gdk_event_dispatch () from /usr/lib/libgdk-1.2.so.0
#14 0x401c7c46 in g_main_dispatch () from /usr/lib/libglib-1.2.so.0
#15 0x401c8273 in g_main_iterate () from /usr/lib/libglib-1.2.so.0
#16 0x401c843c in g_main_run () from /usr/lib/libglib-1.2.so.0
#17 0x400e076c in gtk_main () from /usr/lib/libgtk-1.2.so.0
#18 0x0809979d in ui_main (argc=1, argv=0xbffff624) at gui_main.c:959
#19 0x080657bf in main (argc=5, argv=0xbffff624) at civclient.c:244
#20 0x4034e7ee in __libc_start_main () from /lib/libc.so.6


Core was generated by `civclient -t trident -P none'.
Program terminated with signal 11, Segmentation fault.
406         assert(pf_last_position(dest_path)->x ==
src_path->positions[0].x);
(gdb) bt
#0  0x080b2f3d in pft_concat (dest_path=0x84afff8, src_path=0x0) at
pf_tools.c:406
#1  0x0806cb85 in send_goto_route (punit=0x839a738) at goto.c:544
#2  0x0806b43c in do_unit_goto (x=53, y=22) at control.c:1385
#3  0x0806b20a in do_map_click (xtile=53, ytile=22) at control.c:1316
#4  0x0807010b in action_button_pressed (canvas_x=401, canvas_y=310) at
mapctrl_common.c:86
#5  0x0809f7bf in butt_down_mapcanvas (w=0x83269a8, ev=0x8346028) at
mapctrl.c:337
#6  0x400e1f2f in gtk_marshal_BOOL__POINTER () from /usr/lib/libgtk-1.2.so.0
#7  0x40114268 in gtk_handlers_run () from /usr/lib/libgtk-1.2.so.0
#8  0x4011363f in gtk_signal_real_emit () from /usr/lib/libgtk-1.2.so.0
#9  0x40111597 in gtk_signal_emit () from /usr/lib/libgtk-1.2.so.0
#10 0x4014a4ec in gtk_widget_event () from /usr/lib/libgtk-1.2.so.0
#11 0x400e1e65 in gtk_propagate_event () from /usr/lib/libgtk-1.2.so.0
#12 0x400e0eaf in gtk_main_do_event () from /usr/lib/libgtk-1.2.so.0
#13 0x40195dd4 in gdk_event_dispatch () from /usr/lib/libgdk-1.2.so.0
#14 0x401c7c46 in g_main_dispatch () from /usr/lib/libglib-1.2.so.0
#15 0x401c8273 in g_main_iterate () from /usr/lib/libglib-1.2.so.0
#16 0x401c843c in g_main_run () from /usr/lib/libglib-1.2.so.0
#17 0x400e076c in gtk_main () from /usr/lib/libgtk-1.2.so.0
#18 0x0809979d in ui_main (argc=1, argv=0xbffff624) at gui_main.c:959
#19 0x080657bf in main (argc=5, argv=0xbffff624) at civclient.c:244
#20 0x4034e7ee in __libc_start_main () from /lib/libc.so.6


civclient: path_finding.c:732: create_danger_segment: Zusicherung
»!pf_map->d_lattice[index].is_dangerous« nicht erfüllt.
Core was generated by `civclient -t trident -P none'.
Program terminated with signal 6, Aborted.
#0  0x4035f861 in kill () from /lib/libc.so.6
#1  0x4035f665 in raise () from /lib/libc.so.6
#2  0x40360c81 in abort () from /lib/libc.so.6
#3  0x40359a52 in Letext () from /lib/libc.so.6
#4  0x080b1e8f in create_danger_segment (pf_map=0x85614e8,
dir=DIR8_NORTHWEST, 
    d_node1=0x85b5b14, length=4) at path_finding.c:732
#5  0x080b2197 in danger_iterate_map (pf_map=0x85614e8) at
path_finding.c:879
#6  0x080b1241 in pf_next (pf_map=0x85614e8) at path_finding.c:250
#7  0x080b27f9 in danger_get_path (pf_map=0x85614e8, x=55, y=19) at
path_finding.c:1107
#8  0x080b1ba9 in pf_get_path (pf_map=0x85614e8, x=55, y=19) at
path_finding.c:615
#9  0x0806c06c in update_last_part (x=55, y=19) at goto.c:138
#10 0x0806c8e0 in draw_line (dest_x=55, dest_y=19) at goto.c:452
#11 0x08070425 in update_line (canvas_x=460, canvas_y=309) at
mapctrl_common.c:220
#12 0x0809f931 in move_mapcanvas (widget=0x83269a8, event=0x8346028) at
mapctrl.c:365
#13 0x400e1f2f in gtk_marshal_BOOL__POINTER () from /usr/lib/libgtk-1.2.so.0
#14 0x40114268 in gtk_handlers_run () from /usr/lib/libgtk-1.2.so.0
#15 0x4011363f in gtk_signal_real_emit () from /usr/lib/libgtk-1.2.so.0
#16 0x40111597 in gtk_signal_emit () from /usr/lib/libgtk-1.2.so.0
#17 0x4014a4ec in gtk_widget_event () from /usr/lib/libgtk-1.2.so.0
#18 0x400e1e65 in gtk_propagate_event () from /usr/lib/libgtk-1.2.so.0
#19 0x400e0eaf in gtk_main_do_event () from /usr/lib/libgtk-1.2.so.0
#20 0x40195dd4 in gdk_event_dispatch () from /usr/lib/libgdk-1.2.so.0
#21 0x401c7c46 in g_main_dispatch () from /usr/lib/libglib-1.2.so.0
#22 0x401c8273 in g_main_iterate () from /usr/lib/libglib-1.2.so.0
#23 0x401c843c in g_main_run () from /usr/lib/libglib-1.2.so.0
#24 0x400e076c in gtk_main () from /usr/lib/libgtk-1.2.so.0
#25 0x0809979d in ui_main (argc=1, argv=0xbffff624) at gui_main.c:959
#26 0x080657bf in main (argc=5, argv=0xbffff624) at civclient.c:244
#27 0x4034e7ee in __libc_start_main () from /lib/libc.so.6


-- 
Christian Knoke          * * *          http://www.cknoke.de
* Please note new mail address - Neue Mailadresse beachten *
* * * * * * * * *  Ceterum censeo Microsoft esse dividendum.