[Freeciv-Dev] Re: (PR#4781) phantom units showing up on client

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Mon, 11 Aug 2003, Gregory Berkolaiko wrote:

> 
> On Mon, 11 Aug 2003, Jason Short wrote:
> 
> > Unfortunately it's not quite that simple.
> > 
> > I suppose the server must send a unit_info packet to the client to tell
> > them the unit exists, even though the client can't see it.  Then a
> > unit_combat packet is sent that tells of the combat itself.  So if the
> > _client_ is to remove the unit, it should be done at the end of the
> > unit_combat packet.  The attached patch does this, and fixes the problem
> > for your savegame.
> > 
> > But, I think the server should send the unit disband packet (or does
> > this happen as a result of the unit_combat packet?).  Or maybe it
> 
> After some investigation I concluded that
> (a) server disbands unit separately in wipe_unit
> (b) PACKET_REMOVE_UNIT is sent only to clients which can see the unit
> (c) sending it to clients which could see the killer of the unit would be 
> too much I think
> 
> Therefore your patch is the cleanest solution.

And also think about the case when the unseen unit actually wins!  Then no 
packets are sent about it, so the client should definitely remove it 
itself.

G.