[Freeciv-Dev] Re: (PR#4760) take, observe, detach

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

On Thu, Aug 07, 2003 at 09:10:32PM -0700, Jason Short wrote:
> 
> In other words, currently the server is telling the client that the
> player has disconnected, when the client doesn't even know that the
> player was ever connected.  I remember there was a "player list in
> pregame" feature request at one point - for that to work the player info
> should be sent out in pregame (but perhaps it should be a
> short_player_info or some such, without all the game information).

played with the GTK2 client lately? feature is in. and it uses
send_conn_info (connecthand.c:96).
 
> I don't think the two situations are any different.  If anything, they
> should be made more the same - why do we send out player information for
> everyone when a person joins, but only for that player when they leave?
>  Presumably there's a reason for the first method, but there's no
> explanation in the code...

sorry, I was thinking about a different piece of code. No, I'm not sure why
we care about player_info in pregame. conn_info _should_ be good enough?
Perhaps not if there were a saved game or something. hmm. Well, I don't
think the rest of your patch is going to hurt anything.

> > > Should this also include GAME_OVER_STATE?  It's not possible for new 
> > > players to connect at this point, right?  But we still want to send out 
> > > info about disconnecting players, I'd think.
> > 
> > well, ideally GAME_OVER_STATE should last as briefly as possible
> before the
> > (not-as-yet-realized) server switches back to PRE_GAME_STATE and waits for
> > a new game. As long as it doesn't last to long, we can certainly prohibit
> > logins (just don't let sniff_packets() run until we get back to pregame).
> 
> Hmm, that doesn't quite answer my question.  But I think the answer is
> yes, we should send out the packet on logout.

we already to a send_conn_info_remove().

-mike