[Freeciv-Dev] (PR#4760) take, observe, detach

["Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>]

[kauf - Thu Aug  7 14:56:03 2003]:

> observing AI players causes the exit, where observing humans does not:
> 
> the cause is: tech.c:build_required_techs_helper()
> 
>   if (advances[tech].req[0] == goal || advances[tech].req[1] == goal) {
>     freelog(LOG_FATAL, _("tech \"%s\": requires itself"),
>             advances[goal].name);
>     exit(EXIT_FAILURE);
>   }
> 
> when goal=0 "None". This is Jason's commit revision 1.66. Jason?

It happens because the client thinks A_NONE is TECH_UNKNOWN.

A simple fix would be to add a workaround to build_required_techs_helper
for A_NONE.  But this is a hack; I need to go back over the older
changes to find the core of the problem.

jason

4760_hack.diff
Description: 4760_hack.diff