Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2003:
[Freeciv-Dev] Re: (PR#4676) clean up pcity->occupied usage
Home

[Freeciv-Dev] Re: (PR#4676) clean up pcity->occupied usage

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: jdorje@xxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] Re: (PR#4676) clean up pcity->occupied usage
From: "Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Fri, 25 Jul 2003 05:39:17 -0700
Reply-to: rt@xxxxxxxxxxxxxx

On Thu, 24 Jul 2003, Jason Short wrote:

> This patch cleans this usage up in two ways:
> 
> 1.  Instead of pcity->occupied it's now pcity->client.occupied.  This 
> makes it harder to accidentally use it at the server (which was one of 
> the original bugs with this code), and is a prelude for more 
> client-side-only fields (see PR#3771).  Of course this means all users 
> have to be changed.

Good idea!

> 2.  Lots of comments added about the client-side usage of this field. 
> I've satisfied myself that the client side of the code is correct, and 
> put this explanation into the comments.

Well done!

G.





[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] Re: (PR#4676) clean up pcity->occupied usage, Gregory Berkolaiko <=