[Freeciv-Dev] Re: (PR#4674) small clean up in unit vision range calculations

["Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>]

On Thu, 24 Jul 2003, Rafa³ Bursig wrote:

> This is small clean up that remove some duplicate code.

While in principle the changes are good, I think you should
(1) Retire unit_profits_of_watchtower and get_watchtower_vision
altogether
(2) Leave ai/aiunit.c as it is.  We intentionally ignore watchtower there, 
because we need the range at (x,y) and not at the present location of the 
unit.  You can add a comment there, though.  So other people don't get 
tempted to "fix" it.

G.