[Freeciv-Dev] Re: (PR#4610) CMA frontend for Xaw

["Mike Kaufman" <kaufman@xxxxxxxxxxxxxxxxxxxxxx>]

On Fri, Jul 18, 2003 at 09:58:59AM -0700, andrearo@xxxxxxxxxxxx wrote:
> 
> I've written a CMA frontend for the Xaw client, since I usually

looks nice, has some problems though:

o moving the sliders doesn't change any numbers. Your callbacks seem to be
  broken.
o the sliders don't line up with their labels to the left.
o clicking on a preset should not change the city workers, it should not
  control the city.
o so you need a results label like in the gtk dialog. (important)
o you need a close button on the dialog instead of closing the dialog on 
  release and control
o the dialog should not be owned by toplevel. instead it should be owned by
  the city dialog in question.
o I really dislike the transientShellClass. I want a title bar I can grab a
  hold of.

to the code:

the surplus_slider[] and factor_slider[] should go in for loops for widget
creation.

a couple places where you missed spacing, I didn't look too closely:
static char *initial_preset_list[]={
      preset_lines[i]=preset_text[i];
    ret=XawListShowCurrent(list);
    if(ret->list_index!=XAW_LIST_NONE && cmafec_preset_num()) {
  if(ret->list_index!=XAW_LIST_NONE && cmafec_preset_num()) {
  ret=XawListShowCurrent(list);
  if(ret->list_index!=XAW_LIST_NONE && cmafec_preset_num()) {

These lines need to be wrapped to 79 columns...
  my_snprintf(buf, sizeof(buf), _("Food: %6d\nShield: %4d\nTrade:
%5d\nGold: %6d\nLuxury: %4d\nScience: %3d\nCelebrate:"),

-mike