[Freeciv-Dev] Re: New trade rules

[Bursig Rafal <bursig@xxxxxxxxx>]

Dnia 2003.07.17 13:19, Gregory Berkolaiko napisał(a):
> On Thu, 17 Jul 2003, Bursig Rafal wrote:
>
> > Hi all
> >
> > Tomorow I plan commit 4420 , please someone could look on it.
>
> There are some style issues like:
>
> +  can_establish = can_enter_marketplace &&
> +                 can_establish_trade_route(phomecity, pdestcity);
>
> should have && on the new line
>
> +  if(can_enter_marketplace(phomecity, pdestcity))
>
> should have a space between if and (
Thx I will fix that.

> Out of curiosity: what happens if city A can establish the trade 
> route and city B is full and doesn't want the trade route?
Basic rule is that code search min traderoute in all exist B 
traderoutes then this varible is compared with new traderute (AvsB) if 
new is biger then min is removed and new is estabilshed in this place.
This politic is profitable to owner of city B becouse he get better 
traderoute for free.
Other problem is that owner of city B dosen't want trade with owner of 
city A but this is problem of diplomatic code. In future we can 
implement such diplomatic clauses types ( BREAK ALL TRADEROUTES, TRADE 
EMBARGO, etc ) that will support such rules.
Rafal