Complete.Org: Mailing Lists: Archives: freeciv-dev: July 2003:
[Freeciv-Dev] Re: (PR#4528) No freelog in lockfile.c
Home

[Freeciv-Dev] Re: (PR#4528) No freelog in lockfile.c

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: undisclosed-recipients: ;
Subject: [Freeciv-Dev] Re: (PR#4528) No freelog in lockfile.c
From: "Gregory Berkolaiko" <Gregory.Berkolaiko@xxxxxxxxxxxx>
Date: Thu, 10 Jul 2003 15:35:30 -0700
Reply-to: rt@xxxxxxxxxxxxxx

A fix.

G.

On Thu, 10 Jul 2003, Gregory Berkolaiko wrote:

> 
> Compilation fails:
> 
> gcc -DHAVE_CONFIG_H -I. -I. -I../.. -I../../common    -g -O2 -Werror -Wall 
>  -Wpointer-arith -Wcast-align -Wmissing-prototypes -Wmissing-declarations 
>  -c lockfile.c
> cc1: warnings being treated as errors
>  ../../common/log.h:72: warning: `logdebug_check' defined but not used
> 
> Solution:
> 
> either 
>  guard log.h inclusion by the same #ifdefs as are used for freelog 
>  occurences
> or (simpler)
>  add a freelog(LOG_DEBUG, ...) call somewhere
> 
> 
> G.
> 
> 
> 
> 

? log_lock.diff
Index: server/userdb/lockfile.c
===================================================================
RCS file: /home/freeciv/CVS/freeciv/server/userdb/lockfile.c,v
retrieving revision 1.1
diff -u -r1.1 lockfile.c
--- server/userdb/lockfile.c    2003/07/10 03:34:30     1.1
+++ server/userdb/lockfile.c    2003/07/10 22:03:22
@@ -99,6 +99,7 @@
   freelog(LOG_VERBOSE, "FILE_LOCKING not available"); 
 #endif /* HAS_FILE_LOCKING */
 
+  freelog(LOG_DEBUG, "Unable to create lock");
   remove(FC_LOCK_FILE);
   return FALSE;
 }

[Prev in Thread] Current Thread [Next in Thread]
  • [Freeciv-Dev] Re: (PR#4528) No freelog in lockfile.c, Gregory Berkolaiko <=