[Freeciv-Dev] Re: (PR#2581) Layers Patch
[Top] [All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
OK, now I'm back. Layers discussion seems to have faded out
so I'll make a new patch for your review.
> Since there are rather similar wouldn't it be better to have
> something like:
>
> int get_carrier_capacity(int x, int y, struct player *pplayer,
> bool count_units_with_extra_fuel,
> int *missile_cap, int *airunit_cap);
> ?
>
> Raimar
Nobody has commented this. I prefer the functions as they are:
they are quite short so their similarity and differences are
easily visible, and I like a single return value rather than
pointer references.
Now it's your chance to vote, if you are interested.
Juhani
|
|