Complete.Org: Mailing Lists: Archives: freeciv-dev: June 2003:
[Freeciv-Dev] (PR#1870) FreecivAC: borders patch
Home

[Freeciv-Dev] (PR#1870) FreecivAC: borders patch

[Top] [All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index] [Thread Index]
To: ben@xxxxxxxxxxxxxxxxxxxxxx
Subject: [Freeciv-Dev] (PR#1870) FreecivAC: borders patch
From: "Jason Short" <jdorje@xxxxxxxxxxxxxxxxxxxxx>
Date: Fri, 27 Jun 2003 12:52:38 -0700
Reply-to: rt@xxxxxxxxxxxxxx

[ben@xxxxxxxxxxxxxxxxxxxxxx - Fri Jun 27 16:59:03 2003]:

> New version newborders-20030627.patch now available at
> http://freecivac.sourceforge.net/ (newborders-semifog-20030626.patch
> should still apply on top of this). Changes:
> - Applies to current CVS.
> - Fix for a crash which Jason came across, if borders are disabled.
> - Inland lakes/seas are now claimed, by grabbing any ocean tile that has
>   at least 7 adjacent land tiles from the same continent. As Ross
>   pointed out, this is only a temporary solution, and a proper
>   designation of coastal/deep ocean/lake etc. terrain is really required
>   in the long term.

Here's a slightly improved version of the patch.

- In gui-sdl, draw the borders to pBufSurface instead of pDest.  For
fogged tiles these two are not the same.

- Check for game.borders==0 and draw_borders in tile_draw_borders[_iso],
not in the callers.

- In tile_draw_borders, draw only the borders for this tile.  This means
all four directions are drawn.  This could be accomplished in half the
code with an appropriate loop, but we don't have a good iterator for this.

- Minor style fixes.

jason

Attachment: newborders-20030627-jds.diff
Description: newborders-20030627-jds.diff


[Prev in Thread] Current Thread [Next in Thread]